Fix/5642 #5655
Open
Fix/5642 #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures is mutated over the course of the state machine's lifetime
…s tenure, so check this when inferring IBD
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
previously approved these changes
Jan 6, 2025
…s to net::relay since we need to be able to signal to the relayer to _not_ process Stacks blocks
… instructed not to by fault injection
jferrant
approved these changes
Jan 21, 2025
obycode
reviewed
Jan 22, 2025
| @@ -618,6 +618,11 @@ impl Signer { | |||
| "proposed_block_signer_sighash" => %signer_signature_hash, | |||
| "proposed_chain_length" => proposed_block.header.chain_length, | |||
| "expected_at_least" => last_block_info.block.header.chain_length + 1, | |||
| "last_block_info.block.header.consensus_hash" => %last_block_info.block.header.consensus_hash, | |||
| "proposed_block_consensus_hash" => %proposed_block_consensus_hash, | |||
| @@ -618,6 +618,11 @@ impl Signer { | |||
| "proposed_block_signer_sighash" => %signer_signature_hash, | |||
| "proposed_chain_length" => proposed_block.header.chain_length, | |||
| "expected_at_least" => last_block_info.block.header.chain_length + 1, | |||
| "last_block_info.block.header.consensus_hash" => %last_block_info.block.header.consensus_hash, | |||
There was a problem hiding this comment.
The best practice is not to use .s in these keys because systems like Grafana will replace the .s with _s.
| @@ -618,6 +618,11 @@ impl Signer { | |||
| "proposed_block_signer_sighash" => %signer_signature_hash, | |||
| "proposed_chain_length" => proposed_block.header.chain_length, | |||
| "expected_at_least" => last_block_info.block.header.chain_length + 1, | |||
| "last_block_info.block.header.consensus_hash" => %last_block_info.block.header.consensus_hash, | |||
| "proposed_block_consensus_hash" => %proposed_block_consensus_hash, | |||
| "last_block_info.state" => %last_block_info.state, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5642 by adding a dedicated IBD inference rule for Nakamoto. The Stacks node is in IBD mode when either of the following conditions are true:
This (hopefully) fixes some edge cases we've seen on testnet whereby a node can erroneously believe it is not sync'ed when it really is. This had impacted the affected node's ability to participate in StackerDB replication. I intend to test this on naka3.sh, on testnet, and on a single mainnet signer.
Writing the code for that second criterion led to the discoveries of #5649 and #5650, since I had been using
rc_consensus_hashas the ongoing Stacks tenure when in fact it was not.EDIT: this also contains #5667, so let's merge that first.