Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitcoin fork handling in signer #5673

Closed
obycode opened this issue Jan 8, 2025 · 2 comments
Closed

Fix bitcoin fork handling in signer #5673

obycode opened this issue Jan 8, 2025 · 2 comments
Assignees
@jferrant
Labels
locked
Milestone
3.1.0.0.3

Comments

@obycode
Copy link
Contributor

obycode commented Jan 8, 2025

This is related to the failure of tests::signer::v0::bitcoind_forking_test on develop. It needs to be fixed before the next release or we may have a stall when bitcoin forks.

The code in check_block_against_signer_db_state will not sign a block on a bitcoin fork if its height is <= the previous chain tip.
@obycode obycode added this to the 3.1.0.0.3 milestone Jan 8, 2025
@obycode obycode self-assigned this Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 8, 2025
@obycode obycode moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Jan 8, 2025
@obycode
Copy link
Contributor Author

obycode commented Jan 8, 2025

It is caused by the changes here d6bffcf.

@obycode obycode assigned jferrant and unassigned obycode Jan 8, 2025
@jferrant jferrant mentioned this issue Jan 8, 2025
Merged
@aldur aldur closed this as completed Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jan 10, 2025
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jferrant jferrant

Labels
locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.3
Development

No branches or pull requests
4 participants
@obycode @aldur @jferrant @blockstack-devops