opengl shaders #230
Open
opengl shaders #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to keep notes on errors I encountered.
I can place .lib files in the deps/<library_name>/lib to sort them in a bettery way. Therefore I specified those in the include paths.
I updated search paths for static libraries so that it is clearer which library belongs to which dependency.
I would like to have full runnable code because I don't know how would I find matching version for headers that I have downloaded. I've read the licencing and they allow distribution, at least as I understood it, as long as their licence is included in my project. I included their licences in dependencies.
I forgot to replace comment with function that clears resources.
Reuse link_glew_sdl for shaders directory to save time. I don't want to setup and download everything again. I just want to play around with shaders.
* Extract commands to make command easily extensible
* Correct typo I don't know how did the compilation work since the variable was named differently than in fully assembled command. * Place SDL search path before GLEW I don't know does it make a difference, but we first initiate SDL window then GLEW. Because SDL has to create OpenGL context before initializing GLEW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
SOLVE PROBLEM - DON'T COMMIT BINARIES.
Why was the change needed
What was the previous behavior
Checklist
README.md. Likesk-experiments/README.md,sk-experiments/cpp/README.md, etc.Commit
When done, edit the pull request and add the commit content here.