Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Display a button to select the entire row when hovering it in CollectionsEditor (Variable Explorer) #23376

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 30, 2024

Description of Changes

  • This is necessary because in Spyder 6 is not intuitive how to do that since we use a single click to open the editor associated to the cell.
  • Add a test to cover this new UX.

Visual changes

select-row-button

Issue(s) Resolved

Fixes #22524.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@pep8speaks
Copy link

pep8speaks commented Dec 30, 2024

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 217:80: E501 line too long (98 > 79 characters)
Line 218:80: E501 line too long (99 > 79 characters)

Comment last updated at 2025-01-03 14:48:59 UTC

@ccordoba12 ccordoba12 marked this pull request as draft December 30, 2024 17:22
@ccordoba12 ccordoba12 changed the title [WIP] PR: Display a button to select the entire row when hovering it (Variable Explorer) [WIP] PR: Display a button to select the entire row when hovering it in CollectionsEditor (Variable Explorer) Dec 31, 2024
@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Dec 31, 2024
@ccordoba12 ccordoba12 changed the title [WIP] PR: Display a button to select the entire row when hovering it in CollectionsEditor (Variable Explorer) PR: Display a button to select the entire row when hovering it in CollectionsEditor (Variable Explorer) Jan 3, 2025
@ccordoba12 ccordoba12 marked this pull request as ready for review January 3, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to select rows in the Variable Explorer when using Spyder 6
2 participants