PR: Ensure QMenu and QToolBar isinstance checks succeed and remove unneeded wrapper classes
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
dalthviz
changed the title
QMenu submenus are QMenu instancesQMenu, QToolBar and other classes isinstances checks succeed
dalthviz
force-pushed
the
fixes_issue_505
branch
from
2309c82 to
27de0f4
Compare
dalthviz
changed the title
QMenu, QToolBar and other classes isinstances checks succeedQMenu, QToolBar and other classes isinstance checks succeed
dalthviz
changed the title
QMenu, QToolBar and other classes isinstance checks succeedQMenu, QToolBar and other classes isinstance checks succeed and remove unneeded wrapper classes
dalthviz
changed the title
QMenu, QToolBar and other classes isinstance checks succeed and remove unneeded wrapper classes QMenu and QToolBar isinstance checks succeed and remove unneeded wrapper classes
|
My bad. I haven't thought of such a consequence. The changes you've proposed are the only way, then. Apparently, I've removed the test case that led me to the inheritance of the classes. So, I can't review it to see if it was erroneous. As the tests pass, it should be OK. |
ccordoba12
approved these changes
Dec 16, 2024
|
@dalthviz, given the severity of this problem, I think we should release 2.4.3 asap. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
Fixes #505