Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuthnDsl Bug Fix #16339

Closed

Conversation

franticticktick
Copy link
Contributor

Closes gh-16338

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 23, 2024
@rwinch rwinch self-assigned this Jan 10, 2025
@rwinch
Copy link
Member

rwinch commented Jan 10, 2025

Thanks for the pull request @franticticktick!

Since this is a bug, would you please base off of 6.4.x? Also...

Would you be able to split this into two commits referencing a different issue/PR. This helps us & users to track what has changed better since issues/PRs are listed in the changelog. One commit would have the fixes for default configuration. The other would add the disableDefaultRegistrationPage.

I'm fine with this as a single PR if each commit is referencing different issues. Alternatively, you can create multiple PRs instead of multiple issues. Again, the issues/PRs are what go in the changelog so it is valuable to have these as separate items so we can have a concise description of what has changed. Separate commits helps us if we need to do a git bisect at some point to track down a problem.

Thanks again for the PR!

@franticticktick franticticktick changed the base branch from main to 6.4.x January 11, 2025 09:16
@franticticktick
Copy link
Contributor Author

Thanks @rwinch , I overlooked that. Could you review this PR please?

@rwinch
Copy link
Member

rwinch commented Jan 13, 2025

Thanks for the Pull Request! This is now merged into 6.4.x and main via 882766e and decf4de 😄

@rwinch rwinch closed this Jan 13, 2025
@rwinch rwinch added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Kotlin DSL webAuthn { }
3 participants