Support handling multidimensional arrays #34183
Open
+65
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve TODO:
TODO - only handles 2-dimensional arrays
.For method
org.springframework.beans.AbstractNestablePropertyAccessor#newValue
:type
isInteger[][][].class
, it will return a 2-dimensional array instance like[[]]
.After this PR, this method support handling multidimensional arrays:
type
isInteger[][][].class
, it will return a 3-dimensional array instance like[[[]]]
.But actually, this final behavior is correct before this PR. For example:
org.springframework.beans.BeanWrapperAutoGrowingTests#getPropertyValueAutoGrow3dArray
had passed.So I just fix this method
newValue
.