Refactor: Remove redundant logger name usage in SimpleFormatter #43631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the SimpleFormatter implementation, I noticed that the source variable and record.getLoggerName() always return the same value. However, the existing code passes both separately to the String.format method. This seemed redundant, so I made some changes to simplify the implementation.
What has been changed:
Updated the DEFAULT_FORMAT string to reuse source wherever the logger name is needed.
Refactored the format method to pass source just once, removing unnecessary duplication.
Why this change was made:
By reusing the source variable, the code becomes cleaner and easier to understand. It eliminates redundancy without affecting the functionality or output format. The log output remains exactly the same as before.