Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spring-boot.build-image.* should not be read-only #43596

Closed
wants to merge 1 commit into from

Conversation

mpalourdio
Copy link
Contributor

Hi!

With Spring Boot 3.4+, it's now possible to build a docker image from an amd64 host for an arm64 platform. It works and it's awesome!

But while setting the parameter in the pom, or by command line, ie mvn clean -Pnative spring-boot:build-image -Dspring-boot.build-image.imagePlatform=linux/arm64, maven warns :

Parameter 'imagePlatform' (user property 'spring-boot.build-image.imagePlatform') is read-only, must not be used in configuration

IMO, the readonly flag should be removed here

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 23, 2024
@snicoll
Copy link
Member

snicoll commented Dec 23, 2024

IMO, the readonly flag should be removed here

If it should be removed there, it should be removed pretty much in every parameter above where we're applying the exact same thing.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Dec 23, 2024
@mpalourdio
Copy link
Contributor Author

mpalourdio commented Dec 23, 2024

Indeed, I have removed it for all the spring-boot.build-image.* parameters. It's convenient to set them via CLI as the javadoc states, ie Alias for {@link Image#XXXX} to support configuration through command-line, and maven 4 may deny this later IIRC.

@mpalourdio mpalourdio changed the title feat: spring-boot.build-image.imagePlatform should not be read-only feat: spring-boot.build-image.* should not be read-only Dec 23, 2024
@snicoll
Copy link
Member

snicoll commented Jan 6, 2025

Thanks but that would be a breaking change for most users. I've created #43699 to provide more context and we will use this issue to figure out what to do.

@snicoll snicoll closed this Jan 6, 2025
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants