-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ Stream service connection from RabbitMQContainer #42443
Open
eddumelendez
wants to merge
3
commits into
spring-projects:main
Choose a base branch
from
eddumelendez:rabbitmq-stream-service-connection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
.../main/java/org/springframework/boot/autoconfigure/amqp/RabbitStreamConnectionDetails.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.autoconfigure.amqp; | ||
|
||
import org.springframework.boot.autoconfigure.service.connection.ConnectionDetails; | ||
|
||
/** | ||
* Details required to establish a connection to a RabbitMQ service. | ||
* | ||
* @author Eddú Meléndez | ||
* @since 3.4.0 | ||
*/ | ||
public interface RabbitStreamConnectionDetails extends ConnectionDetails { | ||
mhalbritter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* Rabbit server host. | ||
* @return the rabbit server host | ||
*/ | ||
String getHost(); | ||
|
||
/** | ||
* Rabbit server port. | ||
* @return the rabbit server port | ||
*/ | ||
int getPort(); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 129 additions & 0 deletions
129
...ervice/connection/amqp/RabbitStreamContainerConnectionDetailsFactoryIntegrationTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.testcontainers.service.connection.amqp; | ||
|
||
import java.time.Duration; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
import com.rabbitmq.stream.Address; | ||
import com.rabbitmq.stream.Environment; | ||
import org.awaitility.Awaitility; | ||
import org.junit.jupiter.api.Test; | ||
import org.testcontainers.containers.RabbitMQContainer; | ||
import org.testcontainers.images.builder.Transferable; | ||
import org.testcontainers.junit.jupiter.Container; | ||
import org.testcontainers.junit.jupiter.Testcontainers; | ||
|
||
import org.springframework.amqp.rabbit.annotation.RabbitListener; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.boot.autoconfigure.ImportAutoConfiguration; | ||
import org.springframework.boot.autoconfigure.amqp.EnvironmentBuilderCustomizer; | ||
import org.springframework.boot.autoconfigure.amqp.RabbitAutoConfiguration; | ||
import org.springframework.boot.autoconfigure.amqp.RabbitStreamConnectionDetails; | ||
import org.springframework.boot.testcontainers.service.connection.ServiceConnection; | ||
import org.springframework.boot.testsupport.container.TestImage; | ||
import org.springframework.context.annotation.Bean; | ||
import org.springframework.context.annotation.Configuration; | ||
import org.springframework.rabbit.stream.producer.RabbitStreamTemplate; | ||
import org.springframework.rabbit.stream.support.StreamAdmin; | ||
import org.springframework.test.context.TestPropertySource; | ||
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link RabbitStreamContainerConnectionDetailsFactory}. | ||
* | ||
* @author Eddú Meléndez | ||
*/ | ||
@SpringJUnitConfig | ||
@TestPropertySource( | ||
properties = { "spring.rabbitmq.stream.name=stream.queue1", "spring.rabbitmq.listener.type=stream" }) | ||
@Testcontainers(disabledWithoutDocker = true) | ||
class RabbitStreamContainerConnectionDetailsFactoryIntegrationTests { | ||
|
||
private static final int RABBITMQ_STREAMS_PORT = 5552; | ||
|
||
@Container | ||
@ServiceConnection | ||
static final RabbitMQContainer rabbit = getRabbitMqStreamContainer(); | ||
|
||
private static RabbitMQContainer getRabbitMqStreamContainer() { | ||
RabbitMQContainer container = TestImage.container(RabbitMQContainer.class); | ||
container.addExposedPorts(RABBITMQ_STREAMS_PORT); | ||
var enabledPlugins = "[rabbitmq_stream,rabbitmq_prometheus]."; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't use |
||
container.withCopyToContainer(Transferable.of(enabledPlugins), "/etc/rabbitmq/enabled_plugins"); | ||
return container; | ||
} | ||
|
||
@Autowired(required = false) | ||
private RabbitStreamConnectionDetails connectionDetails; | ||
|
||
@Autowired | ||
private RabbitStreamTemplate rabbitStreamTemplate; | ||
|
||
@Autowired | ||
private TestListener listener; | ||
|
||
@Test | ||
void connectionCanBeMadeToRabbitContainer() { | ||
assertThat(this.connectionDetails).isNotNull(); | ||
this.rabbitStreamTemplate.convertAndSend("message"); | ||
Awaitility.waitAtMost(Duration.ofMinutes(4)) | ||
.untilAsserted(() -> assertThat(this.listener.messages).containsExactly("message")); | ||
|
||
} | ||
|
||
@Configuration(proxyBeanMethods = false) | ||
@ImportAutoConfiguration(RabbitAutoConfiguration.class) | ||
static class TestConfiguration { | ||
|
||
@Bean | ||
StreamAdmin streamAdmin(Environment env) { | ||
return new StreamAdmin(env, sc -> { | ||
sc.stream("stream.queue1").create(); | ||
}); | ||
} | ||
|
||
@Bean | ||
EnvironmentBuilderCustomizer environmentBuilderCustomizer() { | ||
return env -> { | ||
Address entrypoint = new Address(rabbit.getHost(), rabbit.getMappedPort(RABBITMQ_STREAMS_PORT)); | ||
env.addressResolver(address -> entrypoint); | ||
}; | ||
} | ||
|
||
@Bean | ||
TestListener testListener() { | ||
return new TestListener(); | ||
} | ||
|
||
} | ||
|
||
static class TestListener { | ||
|
||
private final List<String> messages = new ArrayList<>(); | ||
|
||
@RabbitListener(queues = "stream.queue1") | ||
void processMessage(String message) { | ||
this.messages.add(message); | ||
} | ||
|
||
} | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? Especially given the javadoc, it looks like to me that the existing
RabbitConnectionDetails
should be enough, isn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rabbitmq stream uses a different port and in order to do that the plugin should be enabled. Having two implementations of
RabbitConnectionDetails
will lead to having an exception with 2 beans unless other beans or configuration are disabled when stream are enabled.I think would be possible to have a different virtual host for stream in a single RabbitMQ instance, so, having a specific
ConnectionDetails
would make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a bug in the current code as we're not taking
RabbitConnectionDetails
into account when falling back from stream-specific configuration to general Rabbit configuration. I've opened #42489 for that. When fixed, we'll fallback fromspring.rabbit.stream.*
properties toRabbitConnectionDetails
. With the changes here in place, we'd then fallback fromRabbitStreamConnectionDetails
(a replacement for some of thespring.rabbit.stream.*
properties) toRabbitConnectionDetails
(a replacement for some of the generalspring.rabbit.*
properties).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this some more, Rabbit Streams support is deceptively complicated (to me at least) as I think it's the first time where different users may want different things. One user may want
RabbitConnectionDetails
andRabbitStreamConnectionDetails
to be sourced from the same container as their app is using the same Rabbit broker for both streaming and regular messaging. Another user may wantRabbitConnectionDetails
andRabbitStreamConnectionDetails
to be sourced from different containers as their app is using different Rabbit brokers for streaming and regular messaging.With only
RabbitMQContainer
to look at, even if we could detect in the container connection details factory that the streams plugin is enabled, we wouldn't know if the user wanted this container to be used only for streams or for both streams and regular messaging. It feels like we may need some other signal to indicate how the container should be used as a source for connection details. This reminds me a bit of the exploratory work being done for SSL and the possibility of having SSL-related annotations on the container field. I'll flag this one for a meeting so I can see what the rest of the team thinks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We think we may be able to check to see if the default streams port is exposed by the container. If it isn't, the factory should return
null
.We should also think about Docker Compose as, ideally, we'd keep the supported services in sync across Compose and Testcontainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further thought, I'm not sure that this will work for all cases. Those cases are:
In the two container case,
RabbitContainerConnectionDetailsFactory
will match a container with the streams port exposed and I think we'll end up with a duplicate connection details failure. If we madeRabbitContainerConnectionDetailsFactory
ignore containers with the streams port exposed it would fix the two container case but it would break the one container case.Some experimentation's needed to see if the above's accurate.