Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values for showSummary and showSummaryOutput #38722

Closed
wants to merge 1 commit into from
Closed

Set default values for showSummary and showSummaryOutput #38722

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 10, 2023

This PR changes to set default values for showSummary and showSummaryOutput in LiquibaseProperties to align with its configuration metadata.

See gh-38522

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 10, 2023
@wilkinsona
Copy link
Member

The null values are intentional. Making this change will break compatibility with earlier versions of Liquibase and cause Liquibase423AutoConfigurationTests to fail, effectively reverting #38522.

@wilkinsona wilkinsona closed this Dec 10, 2023
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 10, 2023
@izeye
Copy link
Contributor Author

izeye commented Dec 10, 2023

@wilkinsona Ah, sorry, I missed the point, but I thought default values in configuration metadata are for explicit default values in configuration properties, not for implicit default values. Am I misunderstanding it?

@izeye izeye deleted the gh-38522 branch December 10, 2023 09:24
@wilkinsona
Copy link
Member

wilkinsona commented Dec 10, 2023 •
edited
Loading

They can be used for implicit default values, too, as is the case here. 3e4e59a updated the tests to ensure that the metadata and the implicit defaults are in sync. That said, this is a somewhat unusual situation as we only have this arrangement for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @wilkinsona @spring-projects-issues