Checking for invalid characters in SpringBootContextLoader.setActiveProfiles

[bbulgarelli]

This PR relates to #34062. I created a loop at the beginning of the method that goes through the list of profiles and checks if there are any of these invalid characters: * & ! | ,. If so, an exception is thrown informing which profile is invalid and which characters are prohibited.
I also created the necessary tests to verify the method changes.

[mhalbritter]

Hey, thanks for that. What about the profile names ( and )? I think they should be prohibited, too.

, is interesting:

Of course it doesn't work in the

spring.profiles.active=a,b,

form. But it works in the

spring.profiles.active[0]=a
spring.profiles.active[1]=b
spring.profiles.active[2]=,

form. I still think it's a good idea to deny ,.

[mentallurg]

This pull request has multiple problems.

1. This pull requests addresses a particular case only. What about ':', ';', '/', '', '?'? I suggest completely different approach: Allow letters, digits and hyphen only. Use functions Character.isAlphabetic(), Character.isDigit().

2. Only a single case of profile usage is addressed, the list of active profile. But there are also other cases, when profile names are used, for instance, in the @Profile annotation. The same validation should be used everywhere.

3. Documentation should be extended to describe what profile names will be considered valid.

[wilkinsona]

It has been several months now without the requested feedback so I'm going to close this one. #34062 continues to track the enhancement that we'd like to make here.