Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed "isArticlePage" from conditions, doPlugin has to run at all … #208

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

nickyanalytics
Copy link
Contributor

…pages, removed "no-entry" from channel, we now set channel only if there is an event

Nicole Emer added 2 commits April 8, 2024 13:21
…ages, removed "no-entry" from channel, we now set channel only if there is an event
@nickyanalytics nickyanalytics requested a review from mehakraza April 9, 2024 05:30
@@ -517,9 +518,10 @@ s._articleViewTypeObj = {
const channelCategory = viewTypesResults ? viewTypesResults.channelCategory : '';

if (!s._utils.isAdWall(s)) {
if (s._utils.isArticlePage()) {
//if (s._utils.isArticlePage()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be removed.

Copy link
Contributor

@mehakraza mehakraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nickyanalytics nickyanalytics merged commit 55da90f into master Apr 9, 2024
1 check passed
@nickyanalytics nickyanalytics deleted the TRAC-1906_all_pages_no-entry branch April 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants