Some keys are needed for snowplow and no via window.sp_* available #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehakraza
reviewed
Mar 11, 2024
extensions/doPlugins_global.js
Outdated
| s.eVar44 = s.eVar44 ? s.eVar44 + ',' + event : s.eVar44 = event; | ||
| s.eVar37 = s.prop59 = channel || 'no-entry'; | ||
| s.eVar38 = s.prop60 = channelCategory; | ||
| s.eVar44 = window.sp_events = s.eVar44 ? s.eVar44 + ',' + event : s.eVar44 = event; |
There was a problem hiding this comment.
The else condition should contain 'event' instead of ' s.eVar44 = event'. This might be technically working, but isn't right logically and now with the addition of 'window.sp_events' it won't work as desired.
s.eVar44 = window.sp_events = s.eVar44 ? s.eVar44 + ',' + event : event;
mehakraza
reviewed
Mar 11, 2024
extensions/doPlugins_global.js
Outdated
| s.eVar38 = s.prop60 = channelCategory; | ||
| s._articleViewType = s.eVar44 = window.sp_events += ',' + event; | ||
| s.eVar37 = s.prop59 = window.sp_m_channel = channel || 'no-entry'; | ||
| s.eVar38 = s.prop60 = window.sp_m_channel_category = channelCategory; |
There was a problem hiding this comment.
If there is 'no-entry' in channel and 'channelCategory' is not there it will cause undefined results in eVar38, prop60 and sp_m_channel_category. If we don't want to see undefined values we can simply add an empty string instead. Doing this is not mandatory but might be useful.
s.eVar38 = s.prop60 = window.sp_m_channel_category = channelCategory || '';
mehakraza
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.