Merge pull request #210 from spring-media/TRAC-2028_internal_clicks_s…

…hould_not_send_othe_channel_events _setExternalReferringDomainEvents does not have to run for internal p…
spring-media · May 15, 2024 · 23abc6a · 23abc6a
2 parents fc37a56 + ead0e6e
commit 23abc6a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/extensions/doPlugins/doPlugins_global.js b/extensions/doPlugins/doPlugins_global.js
@@ -537,7 +537,7 @@ s._articleViewTypeObj = {
 };
 
 /**
- * Set additional events with referrer context.
+ * Set additional events with referrer context only (not for trackingValues or internal events). 
  */
 s._setExternalReferringDomainEvents = function (s) {
     const domainsToEventMapping = [
@@ -654,7 +654,11 @@ s._setExternalReferringDomainEvents = function (s) {
         const isDomainMatch = domains && domains.some(domain => {
             return referringURL && referringURL.includes(domain);
         });
-        if (isRegexMatch || isDomainMatch) {
+
+        const isNotTrackingvalue = s._articleViewTypeObj.isOtherTrackingValue() ? false : true;
+        const isNotPageViewFromHome = s._articleViewTypeObj.isFromInternal(referringURL) ? false : true;
+
+        if (isNotTrackingvalue && isNotPageViewFromHome && (isRegexMatch || isDomainMatch)) {
             s._eventsObj.addEvent(event); 
             s.eVar44 = window.utag.data.sp_events = s.eVar44 ? s.eVar44 + ',' + event : event;
             s.eVar37 = s.prop59 = window.utag.data.sp_m_channel = channel || 'no-entry';

diff --git a/tests/doplugins/doplugins_externel_referring_domain.test.js b/tests/doplugins/doplugins_externel_referring_domain.test.js
@@ -6,6 +6,8 @@ describe('External referring domains', () => {
     let addEventMock;
     let getReferrerMock;
     let isArticlePageMock;
+    let isNotTrackingvalueMock;
+    let isNotPageViewFromHomeMock;
 
     beforeEach(() => {
         // Create a fresh window mock for each test.
@@ -17,6 +19,8 @@ describe('External referring domains', () => {
         addEventMock = jest.spyOn(s._eventsObj, 'addEvent').mockImplementation();
         getReferrerMock = jest.spyOn(s._utils, 'getReferrer').mockImplementation();
         isArticlePageMock = jest.spyOn(s._utils, 'isArticlePage').mockImplementation().mockReturnValue(true);
+        isNotTrackingvalueMock = jest.spyOn(s._articleViewTypeObj, 'isOtherTrackingValue').mockImplementation().mockReturnValue(false);
+        isNotPageViewFromHomeMock = jest.spyOn(s._articleViewTypeObj, 'isFromInternal').mockImplementation().mockReturnValue(false);
 
     });