Upgrade Batch guide to support Batch 5 and Boot 3 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buzzardo
reviewed
Dec 6, 2022
| @@ -114,22 +114,8 @@ classes that reduce the need to write custom code. Instead, you can focus on the | |||
| logic. | |||
|
|
|||
| To configure your job, you must first create a Spring `@Configuration` class like the following example in | |||
| `src/main/java/com/exampe/batchprocessing/BatchConfiguration.java`: | |||
|
|
|||
| ==== | |||
There was a problem hiding this comment.
Why remove the code listing?
There was a problem hiding this comment.
The code listing I removed highlighted 3 parts of code:
@EnableBatchProcessing@Autowired JobBuilderFactory@Autowired StepBuilderFactory
All 3 of those components have been removed from the new version of of BatchConfiguration.java so this code snippet was no longer showing any code.
There was a problem hiding this comment.
Good catch. Also, good to know.
| For starters, the `@EnableBatchProcessing` annotation adds many critical beans that | ||
| support jobs and save you a lot of leg work. This example uses a memory-based database | ||
| (provided by `@EnableBatchProcessing`), meaning that, when it is done, the data is gone. It also autowires a couple factories needed further below. | ||
| `src/main/java/com/exampe/batchprocessing/BatchConfiguration.java`. This example uses a memory-based database, |
There was a problem hiding this comment.
I would make the new sentence be a note. I would also reword it into two sentences, so that it's not such a complex sentence:
This example uses an in-memory database. When the application shuts down, no data is retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.