Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to DataSource model #353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljstella
Copy link
Contributor

splunk/security_content#3287 <- PR to add fields to the datasource object.

At the moment, I've typed these incredibly naively with separator_value as an Optional[str], and mitre_components as list[str]. I think separator_value may stay that way, but there's a chance with mitre_components to leverage some of the work we've done elsewhere on MITRE enrichment.

@pyth0n1c
Copy link
Contributor

Minor feedback - in line with latest PEP guidance, we should use
variable_name: None | TypeA
rather than
variable_name: Optional[None]

@pyth0n1c pyth0n1c added 5.0 Targeted for ESCU 5.0 Release Draft and removed 5.0 Targeted for ESCU 5.0 Release labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants