Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding scenario alternatives #3042

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Jan 31, 2025

This fixes the issues plaguing the Scenario dock in DB editor.

Fixes #3041

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (97b6b56) to head (c56e55e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/spine_db_manager.py 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3042   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files         193      193           
  Lines       37255    37257    +2     
  Branches     4472     4473    +1     
=======================================
+ Hits        25040    25043    +3     
+ Misses      10944    10942    -2     
- Partials     1271     1272    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Scenario dock in DB editor didn't work very well due to DB locking
issues.

Re #3041
@soininen soininen force-pushed the 3041_fix_adding_scenario_alternatives branch from 426b767 to c56e55e Compare January 31, 2025 16:05
@soininen soininen merged commit 3de77d6 into master Jan 31, 2025
22 checks passed
@soininen soininen deleted the 3041_fix_adding_scenario_alternatives branch January 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario creation is broken
1 participant