Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database locking issues in DB editor #3040

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Jan 31, 2025

This PR fixes two cases of SQLite objects created in a thread can only be used in that same thread.

No associated issue

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (f129273) to head (954cf69).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
- Coverage   67.21%   67.20%   -0.02%     
==========================================
  Files         193      193              
  Lines       37252    37254       +2     
  Branches     4472     4472              
==========================================
- Hits        25038    25035       -3     
- Misses      10942    10949       +7     
+ Partials     1272     1270       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit fcd005e into master Jan 31, 2025
21 of 22 checks passed
@soininen soininen deleted the fix_db_locking_issues branch January 31, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant