Make multidimension entity naming consistent #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pivot table was creating multidimensional entity names by appending the entity names by the class name plus '__' which we do not do anywhere else. We now use dimension_name_from() and element_name_from() from spinedb_api to have consitent naming everywhere. Re #2423
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #2424 +/- ##
========================================
Coverage 63.89% 63.89%
========================================
Files 195 195
Lines 35446 35445 -1
Branches 5995 5994 -1
========================================
+ Hits 22648 22649 +1
+ Misses 11606 11605 -1
+ Partials 1192 1191 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivot table was creating multidimensional entity names by appending the entity names by the class name plus
__which we do not do anywhere else. We now usename_from_dimensions()andname_from_elements()fromspinedb_apito achieve consistent naming everywhere.Fixes #2423
Checklist before merging