Update validation of egress gateway (#943)

spidernet-io · Nov 7, 2023 · eaf8460 · eaf8460
1 parent 53fbfbf
commit eaf8460
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/egressgateway/egress_gateway_webhook.go b/pkg/egressgateway/egress_gateway_webhook.go
@@ -61,6 +61,11 @@ func (egw *EgressGatewayWebhook) EgressGatewayValidate(ctx context.Context, req
 		return webhook.Denied(fmt.Sprintf("json unmarshal EgressGateway with error: %v", err))
 	}
 
+	if newEg.Spec.NodeSelector.Selector == nil ||
+		(len(newEg.Spec.NodeSelector.Selector.MatchLabels) == 0 && len(newEg.Spec.NodeSelector.Selector.MatchExpressions) == 0) {
+		return webhook.Denied("The field spec.nodeSelector.selector is not set")
+	}
+
 	if egw.Config.FileConfig.EnableIPv4 && !egw.Config.FileConfig.EnableIPv6 {
 		if len(newEg.Spec.Ippools.IPv6) != 0 {
 			return webhook.Denied("Please do not configure spec.ippools.ipv6, as the current installation settings have not enabled IPv6")