Merge pull request #44 from ragulka/prevent-duplicate-types

Ensure transformed types are unique
spatie · Feb 1, 2023 · 218bd31 · 218bd31
2 parents b88bfe6 + 879eda3
commit 218bd31
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/src/Actions/TranspileTypeToTypeScriptAction.php b/src/Actions/TranspileTypeToTypeScriptAction.php
@@ -66,7 +66,7 @@ private function resolveCompoundType(Compound $compound): string
             iterator_to_array($compound->getIterator())
         );
 
-        return join(' | ', $transformed);
+        return join(' | ', array_unique($transformed));
     }
 
     private function resolveListType(AbstractList $list): string

diff --git a/tests/FakeClasses/Integration/Dto.php b/tests/FakeClasses/Integration/Dto.php
@@ -34,6 +34,9 @@ class Dto extends DataTransferObject
     /** @var int|string */
     public $mixed;
 
+    /** @var int|float */
+    public $number;
+
     /** @var int[] */
     public $documented_array;
 

diff --git a/tests/__snapshots__/DtoTransformerTest__it_will_replace_types__1.txt b/tests/__snapshots__/DtoTransformerTest__it_will_replace_types__1.txt
@@ -10,6 +10,7 @@ array: Array<any>;
 none: any;
 documented_string: string;
 mixed: number | string;
+number: number;
 documented_array: Array<number>;
 mixed_with_array: number | string | Array<number | string>;
 array_with_null: Array<number | null>;

diff --git a/tests/__snapshots__/IntegrationTest__it_can_transform_to_es_modules__1.txt b/tests/__snapshots__/IntegrationTest__it_can_transform_to_es_modules__1.txt
@@ -10,6 +10,7 @@ array: Array<any>;
 none: any;
 documented_string: string;
 mixed: number | string;
+number: number;
 documented_array: Array<number>;
 mixed_with_array: number | string | Array<number | string>;
 array_with_null: Array<number | null>;

diff --git a/tests/__snapshots__/IntegrationTest__it_works__1.txt b/tests/__snapshots__/IntegrationTest__it_works__1.txt
@@ -11,6 +11,7 @@ array: Array<any>;
 none: any;
 documented_string: string;
 mixed: number | string;
+number: number;
 documented_array: Array<number>;
 mixed_with_array: number | string | Array<number | string>;
 array_with_null: Array<number | null>;