-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code health updates #151
Code health updates #151
Conversation
Tests are failing due to this PR: #150 Should we just remove the |
I've remove that faulty test on |
Implicit nullability is deprecated as of PHP 8.4.
We still have some failing tests it seems |
Interesting, apparently |
I'd be ok with a conditional. But I'd also be ok with just dropping support for older Laravel / Pest / PHP versions to fix this. |
What are the lowest versions that you want to support? Do you want to consider dropping PHP <8.1 support as well as Laravel <10 support? |
I'm pretty aggressive with dropping older versions, so this is certainly ok 👍 |
Glad to hear, I like to keep things fresh as well. Working on it, I will push a commit in a few minutes. |
Looks pretty green to me, |
Perfect, thanks! |
tap()
withdefer()
in a test -tap()
is deprecated, it is essentially an alias fordefer()