tabs: Improved API by making brn an hostdirective of hlm #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….component is a directive
|
Awesome! 😎🚀🚀 Thank you for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
You have to add brn and hlm directives to all the tabs components.
Closes #
What is the new behavior?
As we decided to make the hlm dependand on brn, we can simplify the api.
tabs
old:
<brn-tabs value="account">new:
<div brnTabs="account">tabs-list
old:
<brn-tabs-list hlm>new:
<hlm-tabs-list>tabs-trigger
The brn is a hostdirective of the hlm and does not need to be provided.
old:
<button hlmTabsTrigger brnTabsTrigger="account">new:
<button hlmTabsTrigger="account">tabs-content
Same as trigger.
old:
<div hlmTabsContent brnTabsContent="password">new:
<div hlmTabsContent="password">Does this PR introduce a breaking change?
You will get the following error for tabs-list, trigger and content:
Directive BrnTabsTriggerDirective matches multiple times on the same element. Directives can only match an element once.In this case, brnTabsTrigger should be removed. See "new behavior part" of this PR.
Other information
We also added tests for brn-only to make sure @input of brn also still works correctly.