Improved API for tabs by making brn an hostdirective of hlm #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
requested changes
Dec 12, 2023
apps/app/src/app/pages/(components)/components/(tabs)/tabs--vertical.preview.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(components)/components/(tabs)/tabs.preview.ts
Outdated
Show resolved
Hide resolved
apps/app/src/app/pages/(components)/components/(tabs)/tabs.preview.ts
Outdated
Show resolved
Hide resolved
|
Thanks for feedback and improvement suggestions! |
goetzrobin
reviewed
Dec 13, 2023
| </brn-tabs-list> | ||
| <div hlmTabsContent brnTabsContent="account"> | ||
| <div brnTabs="account" class="mx-auto flex max-w-3xl flex-row space-x-2" orientation="vertical"> | ||
| <div hlmTabsList hlm orientation="vertical" aria-label="tabs example"> |
There was a problem hiding this comment.
How do you feel about turning this into ?
I think that would be even cleaner!
There was a problem hiding this comment.
Oh sorry I did not see your comment.
What do you mean by "turning into ?"
….component is a directive
|
Moved to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
You have to add brn and hlm directives to all the tabs components.
Closes #
What is the new behavior?
As we decided to make the hlm dependand on brn, we can simplify the api.
tabs
old:
<brn-tabs value="account">new:
<div brnTabs value="account">tabs-list
old:
<brn-tabs-list hlm>new:
<div hlmTabsList>tabs-trigger
The brn is a hostdirective of the hlm and does not need to be provided.
old:
<button hlmTabsTrigger brnTabsTrigger="account">new:
<button hlmTabsTrigger="account">tabs-content
Same as trigger.
old:
<div hlmTabsContent brnTabsContent="password">new:
<div hlmTabsContent="password">Does this PR introduce a breaking change?
You will get the following error for tabs-list, trigger and content:
Directive BrnTabsTriggerDirective matches multiple times on the same element. Directives can only match an element once.In this case, brnTabsTrigger should be removed. See "new behavior part" of this PR.
Other information
We also added tests for brn-only to make sure @input of brn also still works correctly.