Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(dropdown-menu): add brnMenuTriggerData #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xfraso
Copy link
Contributor

@0xfraso 0xfraso commented Jan 21, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #

#562

What is the new behavior?

This feature allows you to pass context to a dropdown menu template.
By using the cdkMenuTriggerData input, data is passed by setting the brnMenuTriggerData directive and then available using the let- keyword in the scope of the template.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@JohnTNP
Copy link

JohnTNP commented Jan 21, 2025

Hi,
feat(dropdown-menu): add brnMenuTriggerData
should solve the ci / commitlint check.

@0xfraso 0xfraso force-pushed the feature/dropdown-menu-data branch from b50d9c1 to 4cc3fcc Compare January 22, 2025 08:01
@0xfraso
Copy link
Contributor Author

0xfraso commented Jan 22, 2025

Sorry, I just noticed that this is a duplicate of #563.
I'll keep It since this also adds some example in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants