Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolving issue preventing cli from generating all components #516

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ashley-hunter
Copy link
Collaborator

@ashley-hunter ashley-hunter commented Dec 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Selecting "all" in the CLI causes the task to fail:

image

Originally posted on discord:
https://discord.com/channels/1145362148621557921/1314345787337080982

What is the new behavior?

This was because importing json resulted in a default import being included in the returned data. As there is no default component this caused this to fail.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ashley-hunter ashley-hunter marked this pull request as ready for review December 8, 2024 13:29
@goetzrobin goetzrobin merged commit d8ac8d2 into main Dec 9, 2024
7 checks passed
@goetzrobin goetzrobin deleted the fix-ui-generator branch December 9, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants