refactor(pagination): ariaLabel and text as input for localization #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongphuong0905
pushed a commit
to dongphuong0905/spartan
that referenced
this pull request
Nov 23, 2024
dongphuong0905
added a commit
to dongphuong0905/spartan
that referenced
this pull request
Nov 23, 2024
feat(breadcrumb): fix review comment feat(breadcrumb): fix storybook fix(select): updating trigger width on element resize fix(select): updating trigger width on element resize refactor(separator): migration to signals (spartan-ng#449) * refactor(separator): migration to signals Covered areas: BrnSeparatorComponent Already using signals: HlmSeparatorDirective * refactor(separator): revert renaming of orientation and improve types * docs(separator): add default values to storybook refactor(switch): signal migration (spartan-ng#468) * refactor(switch): signal migration * fix: disabled state * refactor: removing rxhostlistener refactor(accordion): migration to signals (spartan-ng#461) docs(select): add missing css import (spartan-ng#444) * docs(select): add missing css import Add the css import '@angular/cdk/overlay-prebuilt.css' (necessary for the component to function properly) in the documentation * docs(select): add missing css import Add the css import '@angular/cdk/overlay-prebuilt.css' (necessary for the component to function properly) in the documentation refactor(avatar)!: migration to signals (spartan-ng#445) * refactor(avatar): migration to signals Covered areas: - HlmAvatarComponent (with updated tests) - BrnAvatarComponent - BrnAvatarFallbackDirective Already using signals: - HlmAvatarImageDirective - HlmAvatarFallbackDirective - BrnAvatarImageDirective * refactor(avatar): switch to new control flow syntax * refactor(avatar): update templates manually for the generator * refactor(avatar): rename inputs to be simpler, dropping the alias BREAKING CHANGE: Renamed useAutoColor to autoColor, userCls to userClass Closes spartan-ng#415 refactor(button)!: migration to signals (spartan-ng#447) * refactor(button): migration to signals * refactor(button): migration to signals * refactor(button): migration to signals * refactor(button): migration to signals * refactor(button): migration to signals * refactor(button): migration to signals * refactor(button): migration to signals refactor(badge): migration to signals (spartan-ng#454) * refactor(badge): migration to signals Closes spartan-ng#419 * docs(badge): add default values to storybook chore(carousel): update embla-carousel-angular to v18 (spartan-ng#410) refactor(progress): migration to signals (spartan-ng#455) refactor(progress): migration to signals refactor(pagination): migration to signals (spartan-ng#457) * refactor(pagination): migration to signals * refactor(pagination): migration to signals refactor(scroll-area): migration to signals (spartan-ng#448) * refactor(scroll-area): migration to signals * refactor(scroll-area): improve input types for boolean transforms * docs(scroll-area): add default values to storybook refactor(sonner): follow conventions and improve type safety (spartan-ng#470) refactor(accordion): remove triggers check, always defined as signal (spartan-ng#473) refactor(tabs): migration to signals (spartan-ng#462) * refactor(tabs): migration to signals * refactor(tabs): format * refactor(tabs): migration to signals * refactor(tabs): remove unused triggers check, triggers is always defined as signal refactor(label): migration to signals (spartan-ng#469) refactor(alert): migrate to signals Revert "refactor(alert): migrate to signals" This reverts commit 250a74b. refactor(alert): migrate to signals (spartan-ng#479) refactor(icon): migrate to signals (spartan-ng#477) refactor(checkbox): migration to signals (spartan-ng#474) * refactor(checkbox): migration to signals * refactor(checkbox): migration to signals * compute state for disabled input and override it internally refactor(toggle): migrate to signals (spartan-ng#472) * refactor(toggle): migrate to signals * refactor(toggle): migrate to signals docs(tooltip): add simple string tooltip example (spartan-ng#390) Co-authored-by: Oleh <[email protected]> feat(breadcrumb): fix formatting feat(breadcrumb): add page nav feat(breadcrumb): fix review comments feat(breadcrumb): reorder breadcrumb by alphabet feat(breadcrumb): fix e2e test feat(breadcrumb): fix review comments feat(breadcrumb): update breadcrumb separator feat(breadcrumb): fix format code feat(collapsible)!: migrate collapsible to signals (spartan-ng#481) refactor(input): migrate to signals (spartan-ng#475) * refactor(input): migrate to signals * refactor(input): change form field controls to public * refactor(input): use input instead of signal for error fix(toggle): sync initial internal toggle group state when toggle con… (spartan-ng#482) * fix(toggle): sync initial internal toggle group state when toggle content children become available closes spartan-ng#408 * refactor(toggle): remove imperative calls to updateSelectionState (spartan-ng#484) --------- Co-authored-by: Benjamin Heiss <[email protected]> fix(avatar): remove unused NgIf import (spartan-ng#486) fix: 300 mobile responsiveness (spartan-ng#487) adds missing spartans feat(calendar): calendar component (spartan-ng#480) build: moving to pnpm, eslint and prettier (spartan-ng#483) feat(breadcrumb): fix format feat(breadcrumb): update eslint path feat(breadcrumb): fix lint feat(breadcrumb): sort import feat(breadcrumb): fix lint for breadcrumb page docs(tooltip): remove unused import (spartan-ng#491) docs(dialog): update docs for dialogs with dynamic content (spartan-ng#494) refactor(pagination): ariaLabel and text as input for localization (spartan-ng#498) refactor(context-menu): migrate to signals (spartan-ng#418) refactor(context-menu): migrate to signals (spartan-ng#418) refactor(context-menu): migrate to signals (spartan-ng#418) refactor(context-menu): migrate to signals (spartan-ng#418) (spartan-ng#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Add
ariaLabelandtextas inputs for previous/next button for localization.