Skip to content

Commit

Permalink
remove support for spack 0.21
Browse files Browse the repository at this point in the history
  • Loading branch information
haampie committed Dec 19, 2024
1 parent 0ce6162 commit ba992b1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 24 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
matrix:
ref:
- develop
- releases/v0.21
- releases/v0.23
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633

Expand All @@ -38,15 +38,6 @@ jobs:
python3 -c 'print("hello world")'
if: matrix.ref == 'develop'

- name: Check build cache install in active env with spack-bash shell (old style)
shell: spack-bash {0}
run: |
spack env activate
spack install --add --cache-only --reuse --no-check-signature python
which python3
python3 -c 'print("hello world")'
if: matrix.ref == 'releases/v0.21'

- name: Check spack-sh shell
shell: spack-sh {0}
run: |
Expand Down
11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Spack
uses: spack/setup-spack@v2
with:
ref: develop # Spack version (examples: develop, releases/v0.21)
ref: develop # Spack version (examples: develop, releases/v0.23)
buildcache: true # Configure oci://ghcr.io/spack/github-actions-buildcache
color: true # Force color output (SPACK_COLOR=always)
path: spack # Where to clone Spack
Expand All @@ -23,15 +23,6 @@ jobs:
When `buildcache: true` is set, binaries from https://github.com/spack/github-actions-buildcache
are used. For available software, [see here](https://github.com/spack/github-actions-buildcache/blob/main/spack.yaml).

**Note**: when using the build cache with Spack v0.21 and below, the following flag is
required:

```
spack install --no-check-signature
```

This flag is no longer required in Spack v0.22.

## Example: shell support

If you want to use shell-aware commands such as `spack env activate` and `spack load`,
Expand Down
6 changes: 2 additions & 4 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ branding:
color: "blue"
inputs:
ref:
description: "Version of Spack (git ref: develop, releases/v0.21, ...)"
description: "Version of Spack (git ref: develop, releases/v0.23, ...)"
required: false
default: develop
buildcache:
Expand Down Expand Up @@ -41,9 +41,7 @@ runs:
- name: Spack configuration
run: |
if [ ${{ inputs.buildcache }} = "true" ]; then
# Spack 0.22 should support the --unsigned flag
spack mirror add --unsigned github-actions-buildcache oci://ghcr.io/spack/github-actions-buildcache || \
spack mirror add github-actions-buildcache oci://ghcr.io/spack/github-actions-buildcache
spack mirror add --unsigned github-actions-buildcache oci://ghcr.io/spack/github-actions-buildcache
fi
shell: sh

Expand Down

0 comments on commit ba992b1

Please sign in to comment.