The token request should not include the scope parameter #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff! 👍 But now that we have one example of an IDP that will fail with "scope" in, and non that require "scope" to be there. I'd say it's safe to remove it. |
soofstad
approved these changes
Dec 6, 2023
soofstad
requested changes
Dec 6, 2023
soofstad
force-pushed
the
bugfix/remove-scope-from-token-request
branch
from
ecf0a0e to
32dbb28
Compare
The scope parameter is not indicated in RFC7636 for inclusion in the token request. It should be removed as it causes issues with strict IDP implementations.
soofstad
force-pushed
the
bugfix/remove-scope-from-token-request
branch
from
32dbb28 to
fb9ad4c
Compare
|
I saw the tests had not ran. So I fixed that and rebased your branch. You can now see that they fail. |
|
I moved the optional scope field to the token refresh request type to correct that. I also updated the test data since the scope parameter is no longer sent in the token request. |
soofstad
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope parameter is not indicated in RFC7636 for inclusion in the token request. It should be removed as it causes issues with strict IDP implementations.
What does this pull request change?
Removes "scope" parameter from token request
Why is this pull request needed?
Including "scope" is a specification violation
Issues related to this change
#129