ASM68K branch improvements #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Personally, I'd rather have this option turned off, but this is the least I can do.
This isn't Z80 code
Forgot to remove a leftover "z" prefix in one part; also caught an instance of a game mode ID that would be problematic if the IDs were to be shuffled around.
I caught this very recently. I'll probably document this all later
This has bugged me for a while now. The S2 and S3K disassemblies call the same animal a penguin, it's called a penguin in official material, and we all know what penguins are... so what's with this name that only makes things hard to understand?
A mistake in the macro code led to its underuse. Some other changes were made for consistency as well.
Finally fixed copyTilemap; writeVRAM and writeCRAM (should these be merged?) had some labels added (which it turns out the AS branch uses...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #64 is at least partially done, I figured I'd share these changes. Some of these are ASM68K-specific while others should apply to all branches.
Some of these have already been merged into this repo before; 0e8e820 and onward are new.