Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase for #1505][syncd] Move logSet logGet under mutex to prevent race condition #1518

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yejianquan
Copy link
Contributor

@yejianquan yejianquan commented Feb 5, 2025

Original PR: #1505
Author: @kcudnik

Create this PR to rebase #1505 to the newest master branch

Fixes: sonic-net/sonic-buildimage#21180

Mutex is added to protect m_logLevelMap when doing logSet from multiple thread

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan changed the title Fix [syncd] Move logSet logGet under mutex to prevent race condition Feb 5, 2025
@yejianquan yejianquan changed the title [syncd] Move logSet logGet under mutex to prevent race condition [Rebase for #1505][syncd] Move logSet logGet under mutex to prevent race condition Feb 5, 2025
@yejianquan
Copy link
Contributor Author

This PR is for bumping up the progress, we will build new chassis image before this Friday, and want to include this fix.
@kcudnik @abdosi for viz

@yejianquan
Copy link
Contributor Author

#1505 rebased already

@yejianquan yejianquan closed this Feb 5, 2025
@yejianquan yejianquan reopened this Feb 5, 2025
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syncd crash in syncd::VendorSai::logSet() during docker startup
3 participants