[syncd] Update log level for bulk api #1492
Open
+114
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
Jan 3, 2025
stephenxs
approved these changes
Jan 3, 2025
stepanblyschak
approved these changes
Jan 3, 2025
kcudnik
previously approved these changes
Jan 4, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
previously approved these changes
Feb 6, 2025
jianyuewu
force-pushed
the
bulkset_loglevel
branch
from
b0781a8 to
abf7b5c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyuewu
force-pushed
the
bulkset_loglevel
branch
from
abf7b5c to
91190cc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Your tests are failing please fix |
Thanks for remind, I'll check it. |
jianyuewu
force-pushed
the
bulkset_loglevel
branch
from
91190cc to
0113ba9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'll try in local firstly, seems some difference in local result. |
|
Thank you, Kamil, I'll check the errors. |
jianyuewu
force-pushed
the
bulkset_loglevel
branch
from
0113ba9 to
18bc5a3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
UT updated and code rebased to latest commit. |
|
Now all tests passed. |
kcudnik
approved these changes
Feb 10, 2025
Log level should be warning instead of error, because functionality is fine. Latter code will fall back to use single api instead of bulk api, when syncd support bulk but sai doesn't support it. Signed-off-by: Jianyue Wu <[email protected]>
jianyuewu
force-pushed
the
bulkset_loglevel
branch
from
18bc5a3 to
6968b8a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log level should be warning instead of error, because functionality is fine. Latter code will fall back to use single api instead of bulk api, when syncd support bulk but sai doesn't support it.
Background
When syncd added support for bulk APIs like bulk set, but sai didn't implement it, this error will be printed:
"processBulkOidSet: bulk set api is not implemented or not supported, object_type = SAI_OBJECT_TYPE_QUEUE", and it will fail the cases. Actually the print should be warning, as in current code, bulk set fall back to single set in latter code, so sai will still receive single set APIs, so functionality is actually OK.
What I did
Update log level from error to warning.
How to verify it
When bulk set api is added in syncd, but sai did not implement it, only warning logs will be printed, instead of error logs.