Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a guide on Core NFTs #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

L0STE
Copy link

@L0STE L0STE commented Feb 18, 2025

Note: I added this PR on the developer repo before it got migrated to solana-com after talking with the Devrel team about creating a new guide on Core NFTs since the current one on NFT is quite outdated

Problem

There wasn't any guides and courses on how to use the new Core NFT standard from Metaplex

Summary of Changes

Added the nfts-with-metaplex-core course at content/courses/tokens-and-nfts/nfts-with-metaplex-core.md with all the information about the new standard + the Lab with a full code example that is ready to use (respecting the same layout and style from the old course on token metadata NFTs)

Changed the callout at nfts-with-metaplex in content/courses/tokens-and-nfts/nfts-with-metaplex.md to link the new guide when talking about the new standard

Copy link

vercel bot commented Feb 18, 2025

@L0STE is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@catalinred catalinred requested a review from ZYJLiu February 21, 2025 17:17
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Feb 24, 2025 4:39pm

@ZYJLiu
Copy link
Collaborator

ZYJLiu commented Feb 24, 2025

Thank you! You'll also need to add the page here for it to show up on the website.

For context, the course is unfortunately in an unmaintained state. Feel free to also removed the outdated metaplex page.

@ZYJLiu ZYJLiu added the documentation Improvements or additions to documentation label Feb 24, 2025
@L0STE
Copy link
Author

L0STE commented Feb 25, 2025

Hey @ZYJLiu thanks for the response, will add the page to show up on the website.

I think keeping the other page is fine since people can still create metaplex NFTs using the Token Metadata standard, Core is just more performant and better.

About the unmaintained state, is there maybe a better place to put this content then? I'm happy to adapt it to whatever format if it means that it gets more eyes from people!

Thank you!

@ZYJLiu
Copy link
Collaborator

ZYJLiu commented Feb 25, 2025

More generally, I think content related to how to use external apps or protocals should remain on their respective documentation and not on solana-com. For this specific page, since you've already taken the time to write it, the course section might be the most appropriate place for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants