Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request paths configurable #65

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

colmsnowplow
Copy link
Contributor

@colmsnowplow colmsnowplow commented Aug 18, 2023

Before this PR, data would be generated for paths at random - including randomly generated paths - the same behaviour is preserved, except the likelihood of random generation for each is now configurable, and one can also optionally add a custom path.

This solves a few problems:

  • Randomly generated paths will create a lot of data that will fail at enrich - for e2e tests this might not be the desired effect
  • Sometimes the random path generated constitutes a redirect path, which the collector correctly rejects
  • If we do want to test redirect paths, without the custom path option we cannot do so
  • We could now distribute load across specific endpoints should we need to

Base automatically changed from feature/httpSink to release/0.6.0 September 12, 2023 07:53
@colmsnowplow colmsnowplow force-pushed the feature/configure-paths branch from 46cccc4 to e189121 Compare September 12, 2023 08:29
Base automatically changed from release/0.6.0 to main September 26, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants