Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/service-deployment add missing deployment labels (closes #185) #186

Merged
merged 2 commits into from
Jul 31, 2024
Merged

charts/service-deployment add missing deployment labels (closes #185) #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca276e7
charts/service-deployment add missing deployment labels (closes #185)
ianarsenault Jul 31, 2024
a222694
prepare for release
ianarsenault Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 0.1.69 (2024-07-31)
---------------------------
charts/service-deployment: Add missing global labels to Deployment (#185)

Version 0.1.68 (2024-07-30)
---------------------------
charts/service-deployment: Add support for global labels applied to resources deployed by the chart (#177)
Expand Down
2 changes: 1 addition & 1 deletion charts/service-deployment/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: service-deployment
description: A Helm Chart to setup a generic deployment with optional service/hpa bindings
version: 0.19.0
version: 0.19.1
icon: https://raw.githubusercontent.com/snowplow-devops/helm-charts/master/docs/logo/snowplow.png
home: https://github.com/snowplow-devops/helm-charts
sources:
Expand Down
2 changes: 2 additions & 0 deletions charts/service-deployment/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: apps/v1
kind: {{ .Values.deployment.kind }}
metadata:
name: {{ include "app.fullname" . }}
labels:
{{ include "snowplow.labels" $ | nindent 4 }}
spec:
{{- if .Values.deployment.scaleToZero }}
replicas: 0
Expand Down
Loading