Skip to content

Commit

Permalink
Adds condition to deploy hook job only when we use private subnet
Browse files Browse the repository at this point in the history
  • Loading branch information
antonis-snowplow committed Oct 31, 2024
1 parent cc83c22 commit 45987f8
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 0.1.80 (2024-10-31)
---------------------------
charts/snowplow-iglu-server: Adds condition to deploy hook job only when we use private subnet (closes #205)

Version 0.1.79 (2024-10-29)
---------------------------
charts/snowplow-iglu-server: Adds missiing variable to fix bug from previous version (closes #205)
Expand Down
2 changes: 1 addition & 1 deletion charts/snowplow-iglu-server/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: snowplow-iglu-server
description: A Helm Chart to deploy the Snowplow Iglu Server project
version: 0.10.1
version: 0.10.2
appVersion: "0.12.0"
icon: https://raw.githubusercontent.com/snowplow-devops/helm-charts/master/docs/logo/snowplow.png
home: https://github.com/snowplow-devops/helm-charts
Expand Down
3 changes: 2 additions & 1 deletion charts/snowplow-iglu-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ When `dev_db` is `true` the hook job `-dev-db-user-setup` will be initiated

### AWS (EKS) settings

When `dev_db` is `true` the hook job `-create-dev-db` will be initiated
When `dev_db` and `deploy_rds_into_private_subnet` are both `true` the hook job `-create-dev-db` will be initiated

#### TargetGroup binding

Expand Down Expand Up @@ -154,6 +154,7 @@ You will need to fill these targeted fields:
| service.annotations | object | `{}` | Map of annotations to add to the service |
| service.aws.targetGroupARN | string | `""` | EC2 TargetGroup ARN to bind the service onto |
| service.aws.dev_db | bool | `false` | Whether we deploy for dev db in AWS |
| service.aws.deploy_rds_into_private_subnet | bool | `false` | Whether we deploy into private subnets |
| service.aws.secrets.admin_username | string | `""` | The admin username that will be used for the psql command |
| service.aws.secrets.admin_password | string | `""` | The admin password that will be used for the psql command |
| service.config.database.dbname | string | `""` | Postgres database name |
Expand Down
2 changes: 2 additions & 0 deletions charts/snowplow-iglu-server/templates/iglu-hooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ spec:
{{- end }}

{{- if .Values.service.aws.dev_db }}
{{- if .Values.service.aws.deploy_rds_into_private_subnet }}

---

Expand Down Expand Up @@ -159,3 +160,4 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/snowplow-iglu-server/values-aws.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ service:

aws:
targetGroupARN: "<target-group-arn>"
deploy_rds_into_private_subnet: "<deploy_rds_into_private_subnet>"
dev_db: "<dev_db>"
prod_dbname: "<prod_dbname>"
secrets:
Expand Down
2 changes: 2 additions & 0 deletions charts/snowplow-iglu-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ service:
targetGroupARN: ""
# -- Whether we deploy for dev db
dev_db: false
# -- Whether we deploy into private subnets
deploy_rds_into_private_subnet: false
prod_dbname: ""
secrets:
admin_username: ""
Expand Down

0 comments on commit 45987f8

Please sign in to comment.