Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 #63

Merged
merged 45 commits into from
Nov 19, 2021
Merged

Bootstrap 4 #63

merged 45 commits into from
Nov 19, 2021

Conversation

smori1983
Copy link
Owner

@smori1983 smori1983 commented Oct 19, 2021

  • bootstrap (4.6.1)
  • bootstrap-colorpicker (3.4.0)

Related topics

itsjavi/bootstrap-colorpicker#333

It seems that spec has been changed to handle hex color as uppercase.

In existing releases, background color is managed as lowercase in local storage.

So change code to:

  • Call .toUpperCase() against fetched data when initializing colorpicker.
  • Call .toLowerCase() when saving data.

@smori1983 smori1983 force-pushed the bootstrap-4 branch 4 times, most recently from 4787ee6 to 3258f24 Compare October 27, 2021 15:47
@smori1983 smori1983 force-pushed the bootstrap-4 branch 4 times, most recently from e44bf2c to 7952d5d Compare November 2, 2021 17:27
@smori1983 smori1983 force-pushed the bootstrap-4 branch 4 times, most recently from 3a58ce4 to d9f7b0d Compare November 11, 2021 15:42
@smori1983 smori1983 force-pushed the bootstrap-4 branch 5 times, most recently from 2918fff to a953515 Compare November 17, 2021 10:22
@smori1983 smori1983 changed the title [WIP] Bootstrap 4 Bootstrap 4 Nov 19, 2021
@smori1983 smori1983 merged commit 1016572 into master Nov 19, 2021
@smori1983 smori1983 deleted the bootstrap-4 branch November 19, 2021 16:25
smori1983 added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant