Enable shapes-only codegen #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
shapes-only
branch
from
5b2ec33 to
46b6ba3
Compare
nateprewitt
previously approved these changes
Feb 12, 2025
|
Changes look good, looks like we have a test failing with the changes though.
|
haydenbaker
reviewed
Feb 18, 2025
JordonPhillips
force-pushed
the
shapes-only
branch
from
46b6ba3 to
56c766e
Compare
|
I refactored this after all the repo structure changes. I made it so that the new plugin is a separate package and abstracted out some of the functionality that was being done by the client's directed codegen so that it could be shared. |
This adds an alternative generation mode that only generates "data shapes".
JordonPhillips
force-pushed
the
shapes-only
branch
from
56c766e to
edb0659
Compare
|
Note that that number of added lines is scarier than reality as I had to copy over a bunch of smithy IDL files for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an alternative generation mode that only generates "data shapes". It's a widely requested feature for both this code generator (I can't tell you how many DMs about this I've received) and for other Smithy generators.
These generated types could still be used in a rich way thanks to the schemas backing them - they could still be plugged into any
ShapeSerializerorShapeDeserializerBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.