Fix: handle positional trait in resources #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the base branch from
Golang/dev
to
fix-addMissingToNativeConv
| """.formatted( | ||
| fromDafnyConvMethodName, | ||
| typeAssertion, | ||
| deReferenceRequired |
There was a problem hiding this comment.
Do we always return a value type for Positional Output? Otherwise this might fail.
| returnResponse = | ||
| "%s(%snative_response)".formatted( | ||
| fromDafnyConvMethodNameForOutput, | ||
| deReferenceRequired ? "*" : "" |
There was a problem hiding this comment.
I prefer this style over what's done at 923.
There was a problem hiding this comment.
Yes. Remove the if else and added ternary instead of it. Now its line 922
ShubhamChaturvedi7
approved these changes
Nov 26, 2024
| w.write( | ||
| """ | ||
| $L($L) ($L error) | ||
| """, | ||
| operationShape.getId().getName(), | ||
| input, | ||
| output | ||
| output.equals("") ? "" : output.concat(",") |
There was a problem hiding this comment.
You can also use .isEmpty() check.
rishav-karanjit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Positional trait was not being handled in Referenced Resources. This PR fixes it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.