Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Upgrade NPM packages, babel-related, axios, etc. #71

Merged
merged 6 commits into from
Feb 14, 2018

Conversation

leeallen337
Copy link
Contributor

@leeallen337 leeallen337 commented Feb 8, 2018

Why?

Issue #64

Update/upgrade packages

What Changed?

  • Removed json-loader
    • Per their documentation, for webpack v2+, importing json files works by default. See here
  • Removed lolex
    • It was not being used in the boilerplate
  • Removed resolve-url-loader
    • It was not being used in the boilerplate
  • Updated/upgraded the below packages
    • eslint-config-smashing-boxes
    • babel-preset-stage-2
    • babel-preset-react
    • babel-preset-es2015
    • babel-loader
      • This needed a major upgrade version (e.g. from v6 to v7) because webpack v3+ needs babel-loader v7+. See here
    • babel-core
    • axios
    • es6-promise
      • Added this import into index.jsx since we always end up doing that for every project anyways

Once Merged

I will update the issue referenced in the Why section

More updates to come. Take a look at the Issue referenced in Why

@ghost ghost assigned leeallen337 Feb 8, 2018
@ghost ghost added the in progress label Feb 8, 2018
@leeallen337 leeallen337 changed the title [WIP] Update packages Update: Upgrade NPM packages, babel-related, axios, etc. Feb 9, 2018
Copy link
Contributor

@mweslander mweslander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the other checks pass, this looks good.

@leeallen337 leeallen337 merged commit f193671 into master Feb 14, 2018
@ghost ghost removed the in progress label Feb 14, 2018
@leeallen337 leeallen337 deleted the feature/upgrade-babel-related-packages branch February 14, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants