golangci-lint #121
Merged
golangci-lint #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
previously approved these changes
Sep 21, 2022
| version: v${{ steps.tool-versions.outputs.golangci-lint_version }} | ||
|
|
||
| # Optional: working directory, useful for monorepos | ||
| working-directory: relayer |
There was a problem hiding this comment.
We should include all Go modules in the monorepo: golangci/golangci-lint#828 (comment)
There was a problem hiding this comment.
Extracted GH Issue: #122 (not blocking)
There was a problem hiding this comment.
Is it possible to use matrix args or something even more automated to repeat for each module?
aalu1418
requested changes
Sep 21, 2022
| @@ -20,7 +20,6 @@ var _ median.MedianContract = (*transmissionsCache)(nil) | |||
| type transmissionsCache struct { | |||
| transmissionDetails TransmissionDetails | |||
| tdLock sync.RWMutex | |||
| tdTime time.Time | |||
There was a problem hiding this comment.
Interesting that this wasn't used...there should be a TTL check here similar to the contract_cache implementation
jmank88
reviewed
Sep 21, 2022
Co-authored-by: Jordan Krage <[email protected]>
aalu1418
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied the latest config from https://github.com/smartcontractkit/chainlink