Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save parent field information to type resolver's target queue #2159

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

MikeEdgar
Copy link
Member

  • Save a discovered field to the TypeResolver's targets queue. This queue will later be used to find the best AnnotationTarget that represents the property
  • Save fields for previously-known properties that are private when privatePropertiesEnable is true

Fixes #2148

@MikeEdgar MikeEdgar added this to the 4.0.7 milestone Jan 15, 2025
@MikeEdgar
Copy link
Member Author

@fastLaugh FYI. You can confirm the expected JSON matches your desired output from #2148

@dhoffer
Copy link

dhoffer commented Jan 17, 2025

What is the estimated timeline of a release with this fix?

@MikeEdgar
Copy link
Member Author

What is the estimated timeline of a release with this fix?

Probably later next week.

phillip-kruger
phillip-kruger previously approved these changes Jan 20, 2025
Adjust tests that no longer make sense

Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MikeEdgar MikeEdgar merged commit bd6420e into smallrye:main Jan 21, 2025
6 of 7 checks passed
@MikeEdgar MikeEdgar deleted the issue-2148 branch January 21, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema annotations lost when interface methods are implemented in a mapped super class
3 participants