fix: Add support for multiple paths #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geniegeist
force-pushed
the
fix-multiple-paths-in-requestmapping
branch
from
cf3a78e to
f5c4f89
Compare
geniegeist
changed the title
geniegeist
force-pushed
the
fix-multiple-paths-in-requestmapping
branch
from
f5c4f89 to
7c9194a
Compare
MikeEdgar
reviewed
Jan 4, 2025
There was a problem hiding this comment.
This is looking good, thanks @geniegeist . Could you have a look at my comment about the distinct path names? I think without that it has the potential to add duplicates in some cases.
core/src/main/java/io/smallrye/openapi/runtime/scanner/spi/AbstractParameterProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/smallrye/openapi/runtime/scanner/ResourceParameters.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Edgar <[email protected]>
geniegeist
force-pushed
the
fix-multiple-paths-in-requestmapping
branch
from
bc70118 to
0603753
Compare
MikeEdgar
approved these changes
Jan 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2118