Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java version in quality workflow #2256

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Jan 14, 2025

The quality workflow is failing because Java 17 is now mandatory to run the build:

Error:  Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:sort (sort-imports) on project smallrye-graphql-parent: Execution sort-imports of goal net.revelc.code:impsort-maven-plugin:1.12.0:sort failed: Unable to load the mojo 'sort' in the plugin 'net.revelc.code:impsort-maven-plugin:1.12.0' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: net/revelc/code/impsort/maven/plugin/SortMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0
Error:  -----------------------------------------------------
Error:  realm =    plugin>net.revelc.code:impsort-maven-plugin:1.12.0
Error:  strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
Error:  urls[0] = file:/home/runner/.m2/repository/net/revelc/code/impsort-maven-plugin/1.12.0/impsort-maven-plugin-1.12.0.jar
Error:  urls[1] = file:/home/runner/.m2/repository/com/github/javaparser/javaparser-core/3.26.2/javaparser-core-3.26.2.jar
Error:  urls[2] = file:/home/runner/.m2/repository/com/google/guava/guava/33.3.0-jre/guava-33.3.0-jre.jar
Error:  urls[3] = file:/home/runner/.m2/repository/com/google/guava/failureaccess/1.0.2/failureaccess-1.0.2.jar
Error:  urls[4] = file:/home/runner/.m2/repository/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar
Error:  urls[5] = file:/home/runner/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
Error:  urls[6] = file:/home/runner/.m2/repository/org/checkerframework/checker-qual/3.43.0/checker-qual-3.43.0.jar
Error:  urls[7] = file:/home/runner/.m2/repository/com/google/errorprone/error_prone_annotations/2.28.0/error_prone_annotations-2.28.0.jar
Error:  urls[8] = file:/home/runner/.m2/repository/com/google/j2objc/j2objc-annotations/3.0.0/j2objc-annotations-3.0.0.jar
Error:  urls[9] = file:/home/runner/.m2/repository/org/codehaus/plexus/plexus-utils/4.0.1/plexus-utils-4.0.1.jar
Error:  Number of foreign imports: 1
Error:  import: Entry[import  from realm ClassRealm[maven.api, parent: null]]
Error:  
Error:  -----------------------------------------------------
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
Error: Process completed with exit code 1.

source: https://github.com/smallrye/smallrye-graphql/actions/runs/12429957229/job/34704891918

@jmini jmini requested a review from a team as a code owner January 14, 2025 05:38
@jmartisk
Copy link
Member

We haven't used that workflow for quite some time and it is probably broken for various other reasons anyway, but yeah we can do this.

@jmartisk jmartisk merged commit 8285309 into smallrye:main Jan 14, 2025
5 checks passed
@github-actions github-actions bot added this to the 2.12.1 milestone Jan 14, 2025
@jmini
Copy link
Contributor Author

jmini commented Jan 15, 2025

I do not like having a red build on the front page of GitHub. But you are right, this is now failing with:

Error:  Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:4.0.0.4121:sonar (default-cli) on project smallrye-graphql-parent: Could not find a default branch for project with key 'smallrye_smallrye-graphql'. Make sure project exists. -> [Help 1]

@jmartisk
Copy link
Member

@jmini, I've disabled it now: 930c099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants