Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child operations from supervision tree AND type_id support #277

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Oct 22, 2024

This patch does 2 things

  1. Adds ability to access the type id and runtime check the message type of an ActorCell. RE: Query the type_id of an actor at runtime #276
  2. Adds ability to stop & drain children actors, by traversing the supervision tree, instead of requiring users to hold the handles themselves in the states. RE: post_stop of children are being called when supervisor fails. #226

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 90.06623% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (defec7f) to head (a230487).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ractor/src/actor/tests/supervisor.rs 93.10% 12 Missing ⚠️
ractor/src/actor/actor_cell.rs 79.48% 8 Missing ⚠️
ractor/src/actor/supervision.rs 88.23% 8 Missing ⚠️
ractor/src/actor/tests/mod.rs 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   80.20%   80.47%   +0.26%     
==========================================
  Files          60       60              
  Lines       10671    10972     +301     
==========================================
+ Hits         8559     8830     +271     
- Misses       2112     2142      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor force-pushed the issues_276_226 branch 3 times, most recently from 8f487ab to f781214 Compare October 23, 2024 14:04
@slawlor slawlor changed the title This patch does 2 things Add child operations from supervision tree AND type_id support Oct 23, 2024
1. Adds ability to access the type id and runtime check the message type of an `ActorCell`. RE: #276
2. Adds ability to stop & drain children actors, by traversing the supervision tree, instead of requiring users to hold the handles themselves in the states. RE: #226
@slawlor slawlor marked this pull request as ready for review October 23, 2024 14:24
@slawlor slawlor merged commit 9fe3d19 into main Oct 23, 2024
13 checks passed
@slawlor slawlor deleted the issues_276_226 branch October 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant