Add silent-retry support for factory messages + support for factories without async-trait
#275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few things.
ractor
crate in order to maintain a higher code quality. This induced a lot of needlesslypub
functions to be marked aspub(crate)
since the visibility was controlled by the parent struct anyways. Additionally a lot ofDebug
implementations are added for publicly exported types.RetriableMessage
which when used in conjunction with aFactory
allows us to automatically retry a message should it be dropped due to a factory worker failing (or panicking). Tests added on this functionality.async-trait
#272 and With async-trait turned off, it is impossible to use factory #248, with the stabilization of async traits natively, factories were gated behind theasync-trait
feature since we utilizeddyn Trait
with async methods, which is not natively supported. For those specific traits (DynamicDiscardController
,FactoryLifecycleHooks
, andWorkerCapacityController
) I've migrated them toBoxFuture<'_, TOutput>
in order to ungate factory usage with native async traits. This is thankfully possible due to the large factory rewrite that occurred in Improvements to the factory construct #237 which greatly improved the factory ergnomics.Resolves #272