New tree component #1693
New tree component #1693
Conversation
| } | ||
|
|
||
| override update(): void { | ||
| // empty |
There was a problem hiding this comment.
Do we want to leave it that way? :)
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export class FlatTreeDataSource<T = any> extends TreeDataSource<T> { | ||
| #mapping: FlatTreeDataSourceMapping<T>; |
There was a problem hiding this comment.
Can you please add spacing between variables and maybe add descriptions as well? :)
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export class NestedTreeDataSource<T = any> extends TreeDataSource<T> { | ||
| #mapping: NestedTreeDataSourceMapping<T>; |
There was a problem hiding this comment.
Can you please add spacing between variables and maybe add descriptions as well?
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export abstract class TreeDataSource<T = any> extends DataSource<T, TreeDataSourceNode<T>> { | ||
| #loadChildren?: TreeDataSourceOptions<T>['loadChildren']; |
There was a problem hiding this comment.
Can you please add spacing between variables and maybe add descriptions as well?
| @property({ attribute: false }) scopedElements?: Record<string, typeof HTMLElement>; | ||
|
|
||
| /** @internal Emits when the user selects a tree node. */ | ||
| @event({ name: 'sl-select' }) selectEvent!: EventEmitter<SlSelectEvent<TreeDataSourceNode<T>>>; |
There was a problem hiding this comment.
I'm just thinking, maybe we should rename SlSelectEvent from sl-select to sth else? Since sl-select is also used for select component?
| if (this.dataSource?.selects === 'multiple') { | ||
| this.setAttribute('aria-multiselectable', 'true'); | ||
| } else { | ||
| this.removeAttribute('aria-multiselectable'); |
There was a problem hiding this comment.
Maybe it should be this.setAttribute('aria-multiselectable', 'false');? So aria-multiselectable="false" by default?
No description provided.