Scalarspeciesproperties #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default behavior of the reader classes is now to raise exceptions whenever not dumped data is requested. This gives more control in the program to intentionally handle that as an exception or allow to show comprehensive error messages.
coherent implementation of atomic particle properties in SingleSpeciesAnalyzer. coherent mapping from ParticleAnalyzer functions to contained SingleSpeciesAnalyzers.
calculations of particle properties may now be done already inside the SingleSpeciesAnalyzer class. Calculations of particle properties which require scalar values on a per species basis (usually mass and charge) will speed up, because these constant values will not be repeated using np.repeat before the calculation. Timed on Laptop with 10e6 particles (timit package, 20 repetitions): calculating gamma 0.43 --> 0.245 sec (57%) calculating Ekin_MeV_qm 0.90 --> 0.36 sec (40%)
skuschel
added a commit
that referenced
this pull request
Dec 29, 2014
handle scalar species properties more efficiently and change reader policy. Trying to access particle properties that arend dumped will now yield a KeyError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12