Feature/log extension #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Mesaglio <[email protected]>
Signed-off-by: Juan Mesaglio <[email protected]>
mesaglio
force-pushed
the
feature/log_extension
branch
from
667ead0 to
4b7ba90
Compare
iago64
previously approved these changes
Dec 23, 2024
RaniAgus
reviewed
Jan 8, 2025
RaniAgus
reviewed
Jan 22, 2025
src/commons/log.c
Outdated
| @@ -44,6 +44,11 @@ static bool _is_level_enabled(t_log* logger, t_log_level level); | |||
|
|
|||
|
|
|||
| t_log* log_create(char* file, char *program_name, bool is_active_console, t_log_level detail) { | |||
| if (!string_ends_with(file, ".log")) { | |||
There was a problem hiding this comment.
Abajo hay un chequeo de if (file != NULL), por lo que entendería que la API soporta pasarle un file nulo y solo imprimir por consola.
There was a problem hiding this comment.
Revisando eso, creo que lo mejor que podemos hacer es ahí apprendear el .log al final del nombre al momento de llamar a file_opened = txt_open_for_append(file); y que les quede de ultima un archivo llamado kernel.log.log, total les va a quedar una vez y a la segunda ya lo "arreglan"
mesaglio
force-pushed
the
feature/log_extension
branch
2 times, most recently
from
dad0842 to
06fd126
Compare
Signed-off-by: Juan Mesaglio <[email protected]>
mesaglio
force-pushed
the
feature/log_extension
branch
from
06fd126 to
d2c35a2
Compare
|
Ahi quedo el cambio con el comment de agus, de hacerlo solo cuando |
iago64
approved these changes
Feb 4, 2025
RaniAgus
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can have less group logs in github
cc @RaniAgus @nahuemazzeo